[Win32] Fix drag and drop on secondary monitor without monitor-specific scaling #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the changes, To reproduce the issue as discussed offline had to do the steps in https://eclipse.dev/eclipse/swt/faq.html#win10dpiawareness the issue is fixed with the changes The change LGTM |
arunjose696
approved these changes
Aug 11, 2025
…atform#2394 To fix drag and drop behavior on multiple monitors with different zooms when using monitor-specific scaling, a recent change adapted the OS callbacks for drop operations to run with the required DPI awareness (PerMonitorV2) in that case. This change did not consider that without monitor-specific scaling (and particularly when DPI awareness "System" is used), running with that modified DPI awareness is not correct. This change adapts the drop callback to only adapt the DPI awareness if appropriate (i.e., if monitor-specific scaling is enabled). Fixes eclipse-platform#2394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix drag and drop behavior on multiple monitors with different zooms when using monitor-specific scaling, a recent change adapted the OS callbacks for drop operations to run with the required DPI awareness (PerMonitorV2) in that case. This change did not consider that without monitor-specific scaling (and particularly when DPI awareness "System" is used), running with that modified DPI awareness is not correct.
This change adapts the drop callback to only adapt the DPI awareness if appropriate (i.e., if monitor-specific scaling is enabled).
Fixes #2394
For reproduction see the original issue. Here is how it looks on 125% secondary monitor (with 100% primary monitor):
Before
After