Revert Deprecation of DefaultSWTFontRegistry #2386
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in LegacySWTFontRegistry (DefaultSWTFontRegistry), fonts were always created using the constructor Font(Device, FontData). However, in ScalingSWTFontRegistry, fonts are now created using the Font(Device, FontData, zoom) constructor.
When fonts are created using Font(Device, FontData), they implicitly use DPIUtil.getNativeDeviceZoom() for scaling. On the other hand, fonts created via the new constructor use the zoom value explicitly passed to SWTFontProvider.getFontHandle(font, zoom)
When DPIUtil.getNativeDeviceZoom() is not equal to passed zoom wrong font sizes occur.
This PR contains two commits.
The first commit is the same as first commit of #2377
This should be merged only after #2377
Fixes #2385