Revert usage of getZoom() when calculating TextExtent #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
2 tasks
HeikoKlare
force-pushed
the
arunjose696/383/revertTextExtent
branch
from
096b0df to
9b884da
Compare
arunjose696
force-pushed
the
arunjose696/383/revertTextExtent
branch
2 times, most recently
from
e92a164 to
b3df19b
Compare
This issue reverts the behavior of GC::textExtent to use the GC::getZoom() instead of the zoom from the font as this results in a regression. Fixes eclipse-platform#2361
HeikoKlare
force-pushed
the
arunjose696/383/revertTextExtent
branch
from
b3df19b to
ba12ac5
Compare
HeikoKlare
approved these changes
Aug 11, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The revert properly fixes the regression for the swt.autoScale=int200 scenario. It will reintroduce the issue reported with:
That issue will be resolved in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue reverts the behavior of
GC::textExtentto useGC::getZoom()instead of the font’s zoom, as the previous change(#2306) introduced a regression.I am yet unable to identify the root cause of the regression. From my understanding, With a monitor zoom of 150 even in the case of
Integer200, the text when drawn withOS.DrawTextis drawn according to monitor zoom (e.g., 150), which aligns withgc.font.zoom. Based on this, it seemed reasonable to use the font’s zoom to calculate the text extent asgc.textExtent()works by drawing text in pixels withOS.drawText()and therefore should convert pixels to points using the zoom the text was drawn with.However, since the change causes a regression which makes eclipse almost unsusable at Integer200, this PR reverts the behavior to its previous state for the M3 release. A more detailed investigation needs to be conducted separately.
Fixes #2361.
Reopens #2311.