Copy Region Handle in Region:copy win32 #2346 #2347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the regression in eclipse-platform#2346 caused by Region:copy. The copied region handle needs to be in the right state as of the original region handle since GC:getClipping(Region) can modify the original region's handle without storing region operations. contributes to eclipse-platform#2346
Test Results 539 files - 7 539 suites - 7 34m 43s ⏱️ + 5m 45s For more details on these failures and errors, see this check. Results for commit 59ffe67. ± Comparison against base commit 5b42ae5. This pull request removes 54 tests. |
HeikoKlare
added a commit
to vi-eclipse/eclipse.platform.swt
that referenced
this pull request
Jul 24, 2025
…platform#2346 The GC#getClipping(Region) call sets the passed region to the current clipping region of the GC. Currently, this is not represented as an operation inside the passed Region, such that when calculating a handle for a different zoom of that region or when copying that region the according application of GC#getClipping(Region) to that region is missing. This change adds the missing operation to the Region. Since the clipping needs to be calculated at the of executing the GC#getClipping(Region) method and not at the time of applying the region operation when retrieving a handle, the GC#getClipping(Region) stores an operation inside GC that maintains handles for the according clipping region at the time of executing the GC#getClipping(Region) method for every zoom at which the GC is requested. This ensures that the proper clipping state is available to the Region. Fixes eclipse-platform#2347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression in #2346 caused by Region:copy. The copied region handle needs to be in the right state as of the original region handle since GC:getClipping(Region) can modify the original region's handle without storing region operations.
contributes to #2346
Note: This is a temporary fix and does not cover the effect for multi zoom scenarios for the case GC:getClipping(Region) is called. A proper follow up solution would be to implement operation strategy for the OS calls called in GC:getClipping(Region) for the region.