Store Region in GC.SetClippingRegionOperation #62 #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
reviewed
Jul 22, 2025
There was a problem hiding this comment.
The changes look sound to me. I have tested them also with GEF Classic, as GEF Classic makes quite some use of this functionality and did not find any issues yet.
I have some rather minor proposals for improvement to avoid unnecessary disposal checks and other executions.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Region.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
Outdated
Show resolved
Hide resolved
This commit refactors GC.SetClippingRegionOperation to store Region and hence refactors GC:setClipping(Region) to call the Operation instead of GC:setClipping(long) for a better behaviour on a GC refresh. Contributes to eclipse-platform#62 and eclipse-platform#128
amartya4256
force-pushed
the
amartya4256/gc_set_clipping_fix
branch
from
1dc4da2 to
eb8fb59
Compare
fedejeanne
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors GC.SetClippingRegionOperation to store Region and hence refactors GC:setClipping(Region) to call the Operation instead of GC:setClipping(long) for a better behaviour on a GC refresh. Additionally this PR also makes Region operations compatible with GC Operation Strategy by following:
Contributes to
#62 and #128