Revert "[win32] Refresh GC with Image based on zoom change" #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of what? Regression? |
|
This reverts commit 8a8c67d, which introduced a regression. Add a manual test to showcase the regression.
fedejeanne
force-pushed
the
revert-win32-image-refresh-gc
branch
from
294a53d to
13d73cf
Compare
|
I guess this was created by accident. We currently investigate a potential regression, but will first focus on resolving it. If we don't manage to achieve that until M2, we may consider reverting the causing commit. |
|
It was not created by accident but as a fail-safe in case we can't find a solution until M2. It will remain drafted so we can work on a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a8c67d.