[win32] Ensure correct DPI awareness for DnD #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
force-pushed
the
win32-ensure-dnd-with-dpi-awareness
branch
from
db566e0 to
23b19b0
Compare
This commit sets temporarily the DPI awareness of the thread to PerMonitorV2 if necessary, when DnD operations are executed. This is necessary as the process could be started with System Aware DPI mode which is inherited from the native methods related to DnD. fixes eclipse-platform#2246
fedejeanne
force-pushed
the
win32-ensure-dnd-with-dpi-awareness
branch
from
23b19b0 to
87fffcc
Compare
Sorry @akurtakov, I don't know what that means 😅 It came via E-Mail. Was it intentional? |
|
I have put my phone unlocked in the pocket and it sent a number of random things around while I walked. Sorry about that. |
|
No problem :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets temporarily the DPI awareness of the thread to PerMonitorV2 if necessary, when DnD operations are executed. This is necessary as the process could be started with System Aware DPI mode which is inherited from the native methods related to DnD.
How to test
Its a bit complicated because its not reproducible with runtime. You will need to replace the three affected classes e.g. in the SWT jar of an I-Build with the changes in this PR to see the improvement.
fixes #2246