Skip to content

Preserve handles of images when changing zooms #2139 #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Preserve handles of images when changing zooms #2139 #2140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ private void destroyHandles() {

@Override
void destroyHandlesExcept(Set<Integer> zoomLevels) {
destroyHandles(zoom -> !zoomLevels.contains(zoom) || !this.imageProvider.getPreservedZoomLevels().contains(zoom));
destroyHandles(zoom -> !zoomLevels.contains(zoom) && !this.imageProvider.getPreservedZoomLevels().contains(zoom));
}

private void destroyHandles(Predicate<Integer> filter) {
Expand Down Expand Up @@ -1930,6 +1930,11 @@ ImageData newImageData(int zoom) {
AbstractImageProviderWrapper createCopy(Image image) {
return image.new ExistingImageHandleProviderWrapper(handle, zoomForHandle);
}

@Override
public Collection<Integer> getPreservedZoomLevels() {
return Collections.singleton(zoomForHandle);
}
}

private abstract class ImageFromImageDataProviderWrapper extends AbstractImageProviderWrapper {
Expand Down
Loading