Skip to content

Conversation

@fedejeanne
Copy link
Member

@fedejeanne fedejeanne commented May 5, 2025

Supersedes #2071

Fixes #2057

Requires

How to test

  • Use 2 monitors with different zoom levels (none of them should match the zoom level passed to -Dswt.autoScale in the next step)
  • Run Snippet119 with the following JVM parameters:
    • -Dswt.autoScale=200 (or use another zoom level that doesn't match any of the zooms in your monitors)
    • -Dswt.autoScale.updateOnRuntime=true

Expected: the size of the cursor matches the size of the current monitor and not the one you provided for -Dswt.autoScale

  • Move the window of the snippet to the monitor

Expected: the size of the cursor still matches the size of the current monitor and not the one you provided for -Dswt.autoScale

…ipse-platform#2057

Pass the native zoom to Cursor.win32_getHandle(Cursor, int) instead

Fixes eclipse-platform#2057
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Test Results

   539 files   -  6     539 suites   - 6   33m 16s ⏱️ + 7m 43s
 4 337 tests  - 37   4 321 ✅  - 35   15 💤  - 3  1 ❌ +1 
16 601 runs   - 37  16 463 ✅  - 35  137 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 66f8ada. ± Comparison against base commit dd30aff.

This pull request removes 37 tests.
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

@fedejeanne fedejeanne marked this pull request as ready for review May 5, 2025 09:38
@fedejeanne
Copy link
Member Author

Test failure is unrelated: #1843

@fedejeanne fedejeanne merged commit ee0fdb8 into eclipse-platform:master May 5, 2025
15 of 17 checks passed
@fedejeanne fedejeanne deleted the native_zoom_cursor_2 branch May 5, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom cursor size is doubled with Eclipse 4.35

1 participant