Skip to content

Conversation

@fedejeanne
Copy link
Member

@fedejeanne fedejeanne commented Apr 2, 2025

Downgrade to 2.44.0-2 (from 2.48.0-0ubuntu0.24.04.1). I would have liked to use the previously working version (2.46.6-0ubuntu0.24.04.1) but I wasn't able to provide the correct version string for it. If someone knows it, feel free to improve this solution.

This fixes the obscure errors thrown when running the Linux tests. I found this exception in the logs of the most recent GH Actions runs (all of which fail since 2 days ago):

2025-04-01T15:46:24.5810004Z Running Test_org_eclipse_swt_browser_Browser#test_OpenWindowListener_openHasValidEventDetails[browser flags: 0]
2025-04-01T15:46:24.5810524Z 
2025-04-01T15:46:24.5810839Z ### Descriptors opened BEFORE test_OpenWindowListener_openHasValidEventDetails[browser flags: 0]: 40
2025-04-01T15:46:24.6438504Z /usr/include/c++/13/optional:486: constexpr const _Tp& std::_Optional_base_impl<_Tp, _Dp>::_M_get() const [with _Tp = WebCore::WindowFeatures; _Dp = std::_Optional_base<WebCore::WindowFeatures, false, false>]: Assertion 'this->_M_is_engaged()' failed.

Which led me to believe that the problem was similar to what we already knew from #1564 i.e. that newer versions of WebKit don't work well with our current SWT tests.

Downgrading to an older version of WebKit is just a temporary solution but the best I could come up with given my little knowledge of WebKit.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Test Results

   539 files  +  6     539 suites  +6   33m 14s ⏱️ + 9m 50s
 4 330 tests + 37   4 319 ✅ + 34    9 💤 +2  2 ❌ +1 
16 579 runs  +209  16 476 ✅ +202  101 💤 +6  2 ❌ +1 

For more details on these failures, see this check.

Results for commit 462909d. ± Comparison against base commit 74c39bf.

@fedejeanne fedejeanne marked this pull request as ready for review April 2, 2025 12:27
@fedejeanne
Copy link
Member Author

Windows failures are unrelated

@fedejeanne fedejeanne merged commit f8979dc into eclipse-platform:master Apr 2, 2025
13 of 15 checks passed
@fedejeanne fedejeanne deleted the downgrade_webkit_linux_gh_action branch April 2, 2025 12:41
@fedejeanne
Copy link
Member Author

fedejeanne commented Apr 2, 2025

cc @akoch-yatta , @akurtakov

@fedejeanne
Copy link
Member Author

Downgrade to 2.44.0-2 (from 2.48.0-0ubuntu0.24.04.1). I would have liked to use the previously working version (2.46.6-0ubuntu0.24.04.1) but ...

2.46.6-0ubuntu0.24.04.1 is not provided by Ubuntu 24.04 (Noble): https://packages.ubuntu.com/search?keywords=webkit2gtk-driver, that's why I couldn't use it.

Since I already see that 2.44.0-02 is not provided for Ubuntu 24.10, I can only assume that it will not be provided for the next LTS version either (26.04) which means that this patch will very likely stop working in April 2026. Past that date, if we haven't fixed the underlying issue and we want to stick to Ubuntu 24.04, we need to change the runner from ubuntu-latest to ubuntu-24.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant