Skip to content

Conversation

sratz
Copy link
Member

@sratz sratz commented Feb 18, 2025

With Edge, just as IE did, supports opening new windows on its own, unlike the WebKit implementation on Linux/macOS.

Therefore, to maximize compatibility with IE as the previous default, also let WebView2 handle opening new windows by default.

Fixes #1845.

With Edge, just as IE did, supports opening new windows on its own,
unlike the WebKit implementation on Linux/macOS.

Therefore, to maximize compatibility with IE as the previous default,
also let WebView2 handle opening new windows by default.

Fixes eclipse-platform#1845.
@sratz sratz added the edge Edge Browser label Feb 18, 2025
@sratz sratz added this to the 4.35 RC1 milestone Feb 18, 2025
@sratz sratz requested a review from HeikoKlare February 18, 2025 14:24
@sratz
Copy link
Member Author

sratz commented Feb 18, 2025

@HeikoKlare: I think we should get this into 2025-03 to minimize impact of switching the default.

Copy link
Contributor

Test Results

   502 files  ±0     502 suites  ±0   8m 47s ⏱️ - 1m 0s
 4 334 tests ±0   4 320 ✅ ±0   14 💤 ±0  0 ❌ ±0 
16 575 runs  ±0  16 466 ✅ ±0  109 💤 ±0  0 ❌ ±0 

Results for commit bd0942e. ± Comparison against base commit 7d718fe.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to bring this into 2025-03. We will just need PMC approval given that we are already in freeze period.

@merks
Copy link
Contributor

merks commented Feb 18, 2025

If you guys agree it has my PMC +1

@sratz sratz merged commit a63ba75 into eclipse-platform:master Feb 18, 2025
13 of 14 checks passed
@sratz sratz deleted the edge-newwindow branch February 18, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

edge Edge Browser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SWT Browser widget does not open target="_blank" links

3 participants