Skip to content

Conversation

konczdev
Copy link
Contributor

@konczdev konczdev commented Feb 15, 2025

Overview

This PR adds support for Single Sign-On (SSO) in SWT Browser (using Edge backend),
allowing the browser to leverage the user's Windows credentials for authentication with
Azure AD resources and Microsoft account-enabled websites.

Features

  • Adds a system property to control SSO functionality:
    • org.eclipse.swt.browser.Edge.allowSingleSignOnUsingOSPrimaryAccount
  • The property can be set at instance level with Control.setData
  • Updates README documentation with new property descriptions
  • Implements support for Single Sign-On through the Edge backend

Implementation Details

  • SSO is disabled by default (matches WebView2's default behavior)
  • Either property can be set to true to enable the feature

Documentation

  • Added new section in README explaining the SSO properties and their effects

Related Links

@sratz sratz added the edge Edge Browser label Feb 18, 2025
@konczdev konczdev requested a review from sratz February 19, 2025 07:00
@konczdev
Copy link
Contributor Author

Hello @sratz , is there a chance that this could be included in the next release, since it doesn't come with an API breaking change, or will it only be in the one after that?

@konczdev konczdev force-pushed the feature/sso-support branch from 2ac48bc to a857c99 Compare March 2, 2025 15:37
@konczdev konczdev force-pushed the feature/sso-support branch 3 times, most recently from 0899bdd to 26c8a80 Compare March 16, 2025 20:10
@konczdev konczdev force-pushed the feature/sso-support branch from 26c8a80 to 1994ddf Compare March 21, 2025 07:38
@konczdev konczdev force-pushed the feature/sso-support branch from 1994ddf to b0cfa3d Compare March 30, 2025 10:00
Introduces a new system property to enable Single Sign-On:
- org.eclipse.swt.browser.Edge.allowSingleSignOnUsingOSPrimaryAccount

This allows SWT Browser to use the logged-in Windows account for SSO
with
Azure AD resources and Microsoft account-enabled websites when using the
Edge backend.
@konczdev konczdev force-pushed the feature/sso-support branch from b0cfa3d to 25ff0b4 Compare March 30, 2025 10:01
@konczdev konczdev requested a review from sratz March 30, 2025 10:19
Copy link
Member

@sratz sratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

Any objections, @HeikoKlare?

Copy link
Contributor

Test Results

   545 files  ±0     545 suites  ±0   35m 17s ⏱️ + 3m 59s
 4 367 tests ±0   4 355 ✅ ±0   12 💤 ±0  0 ❌ ±0 
16 616 runs  ±0  16 512 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 25ff0b4. ± Comparison against base commit 8569eb7.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sound, so no objections from my side.

@sratz sratz merged commit 4e6c092 into eclipse-platform:master Apr 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

edge Edge Browser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants