Skip to content

Conversation

akoch-yatta
Copy link
Contributor

This commit unifies the getBounds calculation for ImageDataProvider and ImageFileNameProvider by always scaling the bounds of an existing handle of an image, if the bounds for a different zoom are requested.

fixes #1639

@akoch-yatta akoch-yatta linked an issue Jan 31, 2025 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Test Results

   492 files   -   1     492 suites   - 1   6m 45s ⏱️ - 3m 6s
 4 106 tests  - 190   4 099 ✅  - 186   7 💤  -  3  0 ❌  - 1 
16 157 runs   - 380  16 065 ✅  - 366  92 💤  - 13  0 ❌  - 1 

Results for commit 404155d. ± Comparison against base commit 00c2cf3.

This pull request removes 190 tests.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_afterPageReload[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_String[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_boolean[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_integer[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_javaReturningInt[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_javaReturningString[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_with_multipleValues[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_multiprocess[browser flags: 524,288]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_ClearAllSessionCookies[browser flags: 524,288]
…
This pull request skips 1 test.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_Constructor_multipleInstantiationsInDifferentThreads[browser flags: 0]

♻️ This comment has been updated with latest results.

This commit unifies the getBounds calculation for ImageDataProvider and
ImageFileNameProvider by always scaling the bounds of an existing handle
of an image, if the bounds for a different zoom are requested.

fixes eclipse-platform#1639
@HeikoKlare HeikoKlare merged commit 3e45b23 into eclipse-platform:master Jan 31, 2025
14 checks passed
@HeikoKlare HeikoKlare deleted the fix-1639 branch January 31, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Graphic is disposed" error "Graphic is disposed" on Windows with pull/1496

2 participants