Skip to content

Edge: Set focus after WebView2 initialization of runtime if necessary #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

Edge: Set focus after WebView2 initialization of runtime if necessary #1641

merged 2 commits into from
Dec 10, 2024

Conversation

sratz
Copy link
Member

@sratz sratz commented Dec 9, 2024

Fixes #1640.

@sratz sratz added the edge Edge Browser label Dec 9, 2024
@sratz sratz added this to the 4.35 M1 milestone Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Test Results

   383 files  ±0     383 suites  ±0   4m 36s ⏱️ -8s
 4 096 tests +1   4 089 ✅ +1   7 💤 ±0  0 ❌ ±0 
12 150 runs  +3  12 065 ✅ +1  85 💤 +2  0 ❌ ±0 

Results for commit 0df4680. ± Comparison against base commit f8cbe80.

♻️ This comment has been updated with latest results.

@sratz sratz requested a review from HeikoKlare December 9, 2024 17:09
HeikoKlare
HeikoKlare approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good and works as expected. The provided test is a proper regression test for the issue.

@sratz
Copy link
Member Author

sratz commented Dec 10, 2024

Apparently this was never working on macOS / Cocoa as the test shows.

Disabled the test on macOS and opened #1644

@sratz
Copy link
Member Author

sratz commented Dec 10, 2024

Failing tests on Linux are unrelated.

@sratz sratz merged commit 44dda53 into eclipse-platform:master Dec 10, 2024
9 of 14 checks passed
@sratz sratz deleted the edge-focus branch December 10, 2024 11:52
@HeikoKlare HeikoKlare mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare approved these changes

Assignees

No one assigned

Labels

edge Edge Browser

Projects

None yet

Milestone

4.35 M1

Development

Successfully merging this pull request may close these issues.

Edge: Focus is lost when Browser is made the focus control immediately after construction

2 participants

@sratz @HeikoKlare