Edge: Dark mode support: Use LIGHT instead of AUTO #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
approved these changes
Oct 25, 2024
|
Maybe when we go in the direction of eclipse-platform/eclipse.platform.ui#2440 (inherit from system + auto-adapt theme on-the-fly) we need to use |
Test Results 483 files ±0 483 suites ±0 7m 50s ⏱️ - 2m 18s For more details on these failures, see this check. Results for commit d7dfc74. ± Comparison against base commit 22a6423. ♻️ This comment has been updated with latest results. |
|
Test failures on Linux are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario
we need to explicitly set
as well, as with the previous
it would inherit 'Dark' from the system, which is not desired.
Follow-up on 4d61d1d / #1530.