Add Scrollable.setScrollbarsMode for changing overlay mode #1188
Conversation
wiresketch
requested review from
iloveeclipse,
lshanmug,
niraj-modi and
sravanlakkimsetti
as code owners
Test Results 298 files ±0 298 suites ±0 1h 8m 3s ⏱️ - 1m 46s For more details on these errors, see this check. Results for commit b6b97bd. ± Comparison against base commit 3d87b22. ♻️ This comment has been updated with latest results. |
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
I will update PR in a moment with fixed "since" & rebase on master
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Scrollable.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Scrollable.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Scrollable.java
Outdated
Show resolved
Hide resolved
Add Scrollable.setScrollbarsMode(int) API to provide the possibility to disable/enable overlay scrollbars. Fixes #1184
|
@HannesWell : could you please check what is wrong with the jenkins build? I assume something related to the natives rebuild isn't working as expected. |
The native build works fine (it's visible in the pipeline graph overview), but the subsequent Maven build fails due to out of memory issues: I restarted the build. Sometimes this helps, sometimes one has to wait for times with less overall load in the releng Jenkins instance. |
The latest Jenkins build succeeded. |
What about mac build on github? |
I'm unable to access the logs on my phone, but I just restarted the build and it is at least running for longer than the minute it ran before. |
|
Mac github build seem to fail also in other PRs, like in #1064. |
3 participants
#1184
Add Scrollable.setScrollbarsMode(int) method to provide the possibility to disable/enable overlay scrollbars.
Fixes: #1184