Edge browser fires additional events, e.g. when opened via double click

[dirkfauth]

Describe the bug
We got a Bug report in NatTable that when opening an editor on double click, where the editor opens a Browser of type SWT.EDGE, the editor gets opened again after the first one is closed.

The reason is that the second click on double click seems not to be cleared from the "deferredEvents". Edge.callAndWait() calls Display.readAndDispatch() which in turn calls Display.runDeferredEvents(). This actually means we get an additional mouseUp event after handling the mouseDoubleClick event.

To Reproduce

• Start the following snippet
• Double click on the first button, which opens a Browser in a dialog. In the console you see that you get a mouseUp event and a mouseDoubleClick event
• Double click on the second button "Open Edge Browser in Dialog". In the console you now see that after the mouseDoubleClick event, there is an additional mouseUp event.

public class SnippetEdgeEventIssue {
    public static void main(String[] args) {
        Display display = new Display();
        final Shell shell = new Shell(display);
        shell.setText("Snippet Edge Event Issue");
        shell.setLayout(new RowLayout());

        Button browserButton = new Button(shell, SWT.PUSH);
        browserButton.setText("Open Browser in Dialog");
        browserButton.addMouseListener(new MouseListener() {

            @Override
            public void mouseUp(MouseEvent e) {
                System.out.println("mouse up");
            }

            @Override
            public void mouseDown(MouseEvent e) {
            }

            @Override
            public void mouseDoubleClick(MouseEvent e) {
                System.out.println("mouse double click");

                Shell dialog = new Shell(shell, SWT.DIALOG_TRIM | SWT.APPLICATION_MODAL);
                dialog.setLayout(new FillLayout());

                try {
                    Browser browser = new Browser(dialog, SWT.NONE);
                } catch (SWTError err) {
                    System.out.println("Could not instantiate Browser: " + err.getMessage());
                    display.dispose();
                    return;
                }

                dialog.open();
            }
        });

        Button browserEdgeButton = new Button(shell, SWT.PUSH);
        browserEdgeButton.setText("Open Edge Browser in Dialog");
        browserEdgeButton.addMouseListener(new MouseListener() {

            @Override
            public void mouseUp(MouseEvent e) {
                System.out.println("mouse up");
            }

            @Override
            public void mouseDown(MouseEvent e) {
            }

            @Override
            public void mouseDoubleClick(MouseEvent e) {
                System.out.println("mouse double click");

                Shell dialog = new Shell(shell, SWT.DIALOG_TRIM | SWT.APPLICATION_MODAL);
                dialog.setLayout(new FillLayout());

                try {
                    Browser browser = new Browser(dialog, SWT.EDGE);
                } catch (SWTError err) {
                    System.out.println("Could not instantiate Browser: " + err.getMessage());
                    display.dispose();
                    return;
                }

                dialog.open();
            }
        });

        shell.open();

        while (!shell.isDisposed()) {
            if (!display.readAndDispatch())
                display.sleep();
        }
        display.dispose();
    }
}

Expected behavior
There should be only a mouseUp event followed by a mouseDoubleClick event. The additional mouseUp event should not be fired.

Environment:

1. Select the platform(s) on which the behavior is seen:

• • All OS
• • Windows
• • Linux
• • macOS

2. Additional OS info (e.g. OS version, Linux Desktop, etc)

Windows 11

3. JRE/JDK version

Java 11

Version since
Eclipse or SWT version since when the behavior is seen: 4.24, haven't tested older versions. But it is reported for the current Eclipse version 2024-06.

[deepika-u]

@dirkfauth
I have slightly modified your snippet as below and see same set of events in both the cases being fired on this build.
Version: 2024-12 (4.34)
Build id: I20241022-1800

Can you verify with below snippet and let us know if you are still facing the reported issue even now?

package org.eclipse.swt.bugs5;

import org.eclipse.swt.*;
import org.eclipse.swt.browser.*;
import org.eclipse.swt.events.*;
import org.eclipse.swt.layout.*;
import org.eclipse.swt.widgets.*;

public class SnippetEdgeEventIssue_latest {
    public static void main(String[] args) {
        Display display = new Display();
        final Shell shell = new Shell(display);
        shell.setText("Snippet Edge Event Issue");
        shell.setLayout(new RowLayout());

        Button browserButton = new Button(shell, SWT.PUSH);
        browserButton.setText("Open Browser in Dialog");
        browserButton.addMouseListener(new MouseListener() {

            @Override
            public void mouseUp(MouseEvent e) {
                System.out.println("mouse up1");
            }

            @Override
            public void mouseDown(MouseEvent e) {
            	 System.out.println("mouse down1");
            }

            @Override
            public void mouseDoubleClick(MouseEvent e) {
                System.out.println("mouse double click1");

                Shell dialog = new Shell(shell, SWT.DIALOG_TRIM | SWT.APPLICATION_MODAL);
                dialog.setLayout(new FillLayout());

                try {
                    Browser browser = new Browser(dialog, SWT.NONE);
                } catch (SWTError err) {
                    System.out.println("Could not instantiate Browser: " + err.getMessage());
                    display.dispose();
                    return;
                }

                dialog.open();
            }
        });

        Button browserEdgeButton = new Button(shell, SWT.PUSH);
        browserEdgeButton.setText("Open Edge Browser in Dialog");
        browserEdgeButton.addMouseListener(new MouseListener() {

            @Override
            public void mouseUp(MouseEvent e) {
                System.out.println("mouse up2");
            }

            @Override
            public void mouseDown(MouseEvent e) {
            	System.out.println("mouse down2");
            }

            @Override
            public void mouseDoubleClick(MouseEvent e) {
                System.out.println("mouse double click2");

                Shell dialog = new Shell(shell, SWT.DIALOG_TRIM | SWT.APPLICATION_MODAL);
                dialog.setLayout(new FillLayout());

                try {
                    Browser browser = new Browser(dialog, SWT.EDGE);
                } catch (SWTError err) {
                    System.out.println("Could not instantiate Browser: " + err.getMessage());
                    display.dispose();
                    return;
                }

                dialog.open();
            }
        });

        shell.open();

        while (!shell.isDisposed()) {
            if (!display.readAndDispatch())
                display.sleep();
        }
        display.dispose();
    }
}

I get below events as seen from console, in both kind of browser objects i get same set of events triggered.
mouse down1
mouse up1
mouse down1
mouse double click1
mouse down2
mouse up2
mouse down2
mouse double click2

[dirkfauth]

I downloaded the latest i-build and executed the tests as before. Looks good to me now. Thanks!

[deepika-u]

Does that mean i can close this issue?

[dirkfauth]

I think so, yes.

[deepika-u]

Not facing this issue anymore as per @dirkfauth, so this can be closed.