Skip to content

consider default parallelism #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

consider default parallelism #4815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b9833
consider default parallelism
branfosj Mar 15, 2025
9a91bb9
add missing :
branfosj Mar 15, 2025
2c0d30c
unbreak the tests
branfosj Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion easybuild/tools/systemtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,14 +1240,19 @@ def get_default_parallelism():
det_parallelism._default_parallelism = par
return par

defaultpar = get_default_parallelism()
if par is None:
par = get_default_parallelism()
par = defaultpar
else:
try:
par = int(par)
except ValueError as err:
raise EasyBuildError("Specified level of parallelism '%s' is not an integer value: %s", par, err)

if defaultpar < par:
Copy link
Member

@boegel boegel Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--parallel was always meant to provide full control, I think we need to introduce a --max-parallel options instead

Copy link
Member

@boegel boegel Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see:

_log.info("Reducing parallelism from %s to %s", par, defaultpar)
par = defaultpar

if maxpar is not None and maxpar < par:
if maxpar is False:
maxpar = 1
Expand Down
Loading