add terse support to --missing-modules
#4407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to have the missing modules in a format that can be processed in a script, i.e. one EC name per line. So allow `--terse` in combination with `--missing-modules`.
boegel
modified the milestones:
next release (4.9.0?),
next release (4.9.0),
release after 4.9.0
Contributor
Author
|
Any news here? I just used this as |
Member
|
@Flamefire I took a quick look at this, and while I'm certainly all for improving the output of |
boegel
requested changes
Apr 3, 2024
…ined with --missing-modules
boegel
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to have the missing modules in a format that can be processed in a script, i.e. one EC name per line.
So allow
--tersein combination with--missing-modules.@boegel I needed to adjust the early-exit to not exit for this case. Can you think of any situation where this might be an issue?
Example use case I wanted to have:
eb $(eb PyTorch-2.1.0-foss-2022a.eb -M --terse | grep -v PyTorch) -rto install all missing dependencies.