Skip to content

Fix compilation errors on Node.js 13 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2020
Merged

Fix compilation errors on Node.js 13 #9

merged 1 commit into from
Feb 27, 2020

Conversation

lehni
Copy link

@lehni lehni commented Feb 5, 2020 •
edited
Loading

This works for me on Node.js 13. I haven't tested backward compatibility though

@lehni lehni force-pushed the fix-compilation-errors branch from 067c232 to dd08800 Compare February 5, 2020 14:17
@keptan
Copy link
Collaborator

keptan commented Feb 13, 2020

Thanks for contributing your work!
I'll have to check how this works out with our production build, but it looks promising to make this package more accessible to people without our specific setup.

@keptan keptan mentioned this pull request Feb 22, 2020
Closed
@keptan
Copy link
Collaborator

keptan commented Feb 27, 2020

tested, merging

@keptan keptan merged commit 7aeb74d into easybotics:master Feb 27, 2020
@lehni
Copy link
Author

lehni commented Feb 28, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehni @keptan