Skip to content

Rename brightness() to setBrightness() #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename brightness() to setBrightness() #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/ledmatrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ class LedMatrix : public node::ObjectWrap
void DrawText (int, int, std::tuple<int, int, int>, const char* text, const char* fontFile);
void DrawCircle (int, int, int, std::tuple<int, int, int>);
void DrawLine (int, int, int, int, std::tuple<int, int, int>);
void Brightness (int);
void SetBrightness (int);

void Update (void);

protected:
LedMatrix (int rows , int cols , int chained_displays , int parallel_displays, int brightness, const char* mapping, const char* rgbSeq, std::vector<std::string> flags);
LedMatrix (int rows, int cols, int chained_displays , int parallel_displays, int brightness, const char* mapping, const char* rgbSeq, std::vector<std::string> flags);

virtual ~LedMatrix (void);

Expand All @@ -74,7 +74,7 @@ class LedMatrix : public node::ObjectWrap
static void DrawText (const Nan::FunctionCallbackInfo<v8::Value>& args);
static void DrawCircle (const Nan::FunctionCallbackInfo<v8::Value>& args);
static void DrawLine (const Nan::FunctionCallbackInfo<v8::Value>& args);
static void Brightness (const Nan::FunctionCallbackInfo<v8::Value>& args);
static void SetBrightness (const Nan::FunctionCallbackInfo<v8::Value>& args);

static void Scroll (const Nan::FunctionCallbackInfo<v8::Value>& args);
static void UV_Scroll (uv_work_t* work);
Expand Down
8 changes: 4 additions & 4 deletions src/ledmatrix.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void LedMatrix::Init (v8::Local<v8::Object> exports)
Nan::SetPrototypeMethod(tpl, "drawText", DrawText);
Nan::SetPrototypeMethod(tpl, "drawCircle", DrawCircle);
Nan::SetPrototypeMethod(tpl, "drawLine", DrawLine);
Nan::SetPrototypeMethod(tpl, "brightness", Brightness);
Nan::SetPrototypeMethod(tpl, "setBrightness", SetBrightness);

constructor.Reset(tpl->GetFunction());

Expand Down Expand Up @@ -365,20 +365,20 @@ void LedMatrix :: DrawLine (const Nan::FunctionCallbackInfo<Value>& args)

return matrix->DrawLine( x0, y0, x1, y1, std::make_tuple(r, g, b));
}
void LedMatrix :: Brightness (int b)
void LedMatrix :: SetBrightness (int b)
{

matrix->SetBrightness(b);
}

void LedMatrix :: Brightness (const Nan::FunctionCallbackInfo<Value>& args)
void LedMatrix :: SetBrightness (const Nan::FunctionCallbackInfo<Value>& args)
{
LedMatrix* matrix = ObjectWrap::Unwrap<LedMatrix>(args.Holder());
int b = 100;

b = args[0]->ToInteger()->Value();

return matrix->Brightness(b);
return matrix->SetBrightness(b);
}


Expand Down