[ FIX ] Missing cache.service replaced by emag.cache.service #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devrck
commented
Dec 15, 2016
devrck
commented
- fix missing cache.service (was replaced by emag.cache.service)*
- assign variables to avoid allocating again and again new references to services
- build new wrapper using cascading calls;
- remove return because nobody is using the return of this function and seems useless to keep track of objects that will not be usefull for anybody
…assign variables to avoid allocating again and again new references to services; build new wrapper using cascading calls;
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.