This repository was archived by the owner on Dec 29, 2020. It is now read-only.
converter: apply whitelist filtering on supported types #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍! Can you provide a test? Btw, can you add support for common aliases like |
Only in effect on all-lowercase types. This is to filter out stuff like `mixed`, `void`, `$this`, etc.
|
src/Converter.php
Outdated
| return 'callable'; | ||
|
|
||
| case 'void': | ||
| return 'null'; |
There was a problem hiding this comment.
Thx, force-pushed an update!
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only in effect on all-lowercase types. This is to filter out stuff like
mixed,void,$this, etc.Currently return type hints like
mixed,voidor$this, which are quite common, get converted literally into PHP.mixedandvoidare expected to be classes,$thisisn't an allowed syntax.The idea of this PR is that, in case the whole type hint is in lowercase, it must be one of the supported type declarations as listed at http://php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration ; otherwise the type hint gets just ignroed.
This automatically filters out a lot of unsupported stuff.
An edge case is when referring to all-lowercase classes. This PR wouldn't support them.
If this is acceptable, I can provide tests too.