Save and Exit: Add FF and update links #6852
Open
+259
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
changed the title
0nko
force-pushed
the
feature/ondrej/save-and-exit-links
branch
from
d5107aa to
3444f67
Compare
0nko
force-pushed
the
feature/ondrej/save-and-exit-links
branch
2 times, most recently
from
2aa7125 to
cc4c1a2
Compare
|
|
||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| @Toggle.InternalAlwaysEnabled | ||
| fun saveAndExitSerpSettings(): Toggle |
There was a problem hiding this comment.
I kinda feel you want another FF specific to using the new settings activity, appreciate that code is in the next PR though.
There was a problem hiding this comment.
I suppose since we're getting rid of the Save and Exit button I guess it should be called something like SettingsWebView but why would we need another FF?
There was a problem hiding this comment.
Yeah agreed, I'd rename to settingsWebView. The second feature flag is less relevant now but I left a message on the other PR explaining my reasoning (I think we can still do it).
This reverts commit 04a1c4a.
0nko
force-pushed
the
feature/ondrej/save-and-exit-links
branch
from
cc4c1a2 to
e3e06cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1211395150174608
Description
This PR adds a FF and updates the private search and duck.ai settings links.
Steps to test this PR
QA-optional