UI for bookmarks import flow #6836

CDRussell · 2025-09-23T12:01:59Z

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211407036705134?focus=true

Description

Adds UI to the bookmarks import flow, as well as a few more options in internal dev settings for testing them.

This is still only accessible via Autofill Dev Settings screen (i.e., doesn't allow for flow to start in production)

Steps to test this PR

Suggested logcat filter: Bookmark-import
Perform a clean install on this branch, using internal build type

Pre-import dialog

In Autofill Dev Settings, tap on Launch Bookmarks import flow (with preimport dialog)
Verify you see the dialog

Verify you can cancel the dialog using the back button, the X button and by tapping outside of it
In the dialog, tap Import Now and verify it launches the web flow

Web Flow, cancellations

Carrying on from the previous test

Tap the X button, verifying you are prompted if you're sure you want to cancel. Choose Cancel Import
Verify the web flow ends, and you still see the pre-import dialog
Tap Import Now again, and this time use the back button, confirming you see the cancellation confirmation prompt

Web flow, from a logged out state

You should not be logged in to a Google account already (which should be true if you're following these steps)

Launch the web flow, verifying you can see the WebView asking you to sign into your Google account
Sign in, verifying the WebView is no longer visible and an in progress page shows instead
Wait for the flow to complete
(Optionally) You may be asked to sign in as the final step; if this happens, you should see the WebView again for it
Verify you see the success screen telling you how many bookmarks were imported

Web flow, from a signed in state

You should be logged in already to a Google account

Launch the web flow, verifying you do NOT see the WebView, and instead jump straight to the in-progress flow
Wait for the flow to complete
(Optionally) You may be asked to sign in as the final step; if this happens, you should see the WebView again for it
Verify you see the success screen telling you how many bookmarks were imported

Web flow, dev-only peeking at the WebView

Launch the web flow and while in the in-progress screen tap on the overflow debug menu to see the WebView
Verify the overlay hides and you can see the WebView automation

CDRussell · 2025-09-23T12:02:17Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

cmonfortep

Some questions about the dev only capabilities I would like to understand.

Leaving some notes around testing in https://app.asana.com/1/137249556945/project/608920331025315/task/1211623356217705?focus=true

autofill/autofill-impl/src/main/res/values/donottranslate.xml

cmonfortep · 2025-10-13T10:38:38Z

autofill/autofill-impl/src/main/res/menu/menu_bookmark_import_debug.xml

+  ~ limitations under the License.
+  -->
+
+<menu xmlns:android="http://schemas.android.com/apk/res/android"


This should go into internal-module.

I don't think it easily can, because the activity still needs to know about the menu and ID. autofill-impl would have to know about autofill-internal (which is the wrong way around)

(could maybe try work around it by having a menu for internal and a stubbed menu for prod, with a real menu item for internal and a fake (invisible) menu item for prod but this sounds worse overall)

I have removed the dev-only tooling from this screen entirely; can revisit how to have this available later again if still needed

cmonfortep · 2025-10-13T10:43:32Z

autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/AutofillCredentialDialogs.kt

 }
+
+@Parcelize
+enum class AutofillImportBookmarksLaunchSource(val value: String) : Parcelable {


Not sure if this is going to change in upstream PRs but we should not expose AutofillDevSettings in api.
We should also surface the api change in api proposal since touches api module.

should not expose AutofillDevSettings in api.

It could be grouped into unknown I guess?

Happy to not have it in the API; will address this in later PR

...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt

...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt

CDRussell · 2025-10-17T11:10:54Z

@cmonfortep i have removed the dev-only capabilities. ready for your re-review.

This was referenced Sep 23, 2025

Add feature flag for importing bookmarks using Google Takeout #6706

Merged

Add ability to parse a Takeout zip file and extract+import bookmarks #6820

Merged

This was referenced Sep 23, 2025

Add webflow for importing bookmarks from Google #6707

Merged

Add web message listener for js call from bookmark import #6837

Open

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from a039a47 to 3f8950c Compare September 23, 2025 13:25

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from b3fac77 to a14e381 Compare September 24, 2025 09:18

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from 77c3176 to 791ae21 Compare September 24, 2025 10:44

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 2 times, most recently from 1713a4f to cb2b5cb Compare September 24, 2025 10:49

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from 4614087 to 9f3b412 Compare September 24, 2025 10:54

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from cb2b5cb to bde236b Compare September 24, 2025 10:54

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from 9f3b412 to 17a6c44 Compare September 24, 2025 10:59

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from bde236b to dfbcd8e Compare September 24, 2025 10:59

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from 17a6c44 to e890ed7 Compare September 24, 2025 11:18

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 2 times, most recently from 7f7ff4b to 2e9a36c Compare September 24, 2025 13:45

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from e890ed7 to b217c11 Compare September 24, 2025 13:45

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 2e9a36c to 7ac6dca Compare September 24, 2025 14:18

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from 0003be7 to a714667 Compare September 25, 2025 13:35

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 7ac6dca to 49ab43d Compare September 25, 2025 13:35

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from a714667 to a8e4b48 Compare September 26, 2025 10:49

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 2 times, most recently from 566d0e5 to 2575f8d Compare September 26, 2025 14:15

CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch from a8e4b48 to 8393d44 Compare September 26, 2025 14:15

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 2575f8d to ad5d7bf Compare September 26, 2025 14:22

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 289bf6e to 4d28998 Compare October 6, 2025 15:00

duckduckgo deleted a comment from Copilot AI Oct 6, 2025

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 8 times, most recently from f942c31 to d2f84e9 Compare October 7, 2025 12:30

CDRussell marked this pull request as ready for review October 7, 2025 12:46

CDRussell assigned cmonfortep Oct 7, 2025

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 4 times, most recently from 204a3c4 to 94ccf12 Compare October 8, 2025 15:56

CDRussell mentioned this pull request Oct 8, 2025

Wire bookmarks import dialog / flow into BookmarksActivity #6909

Open

11 tasks

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 4 times, most recently from 5a34fcc to 591842d Compare October 10, 2025 13:05

cmonfortep reviewed Oct 13, 2025

View reviewed changes

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 4 times, most recently from a9aeca5 to 7549223 Compare October 17, 2025 11:09

CDRussell requested a review from cmonfortep October 17, 2025 11:10

Add UI for importing bookmarks from Google

d9da8a3

CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 7549223 to d9da8a3 Compare October 17, 2025 12:09

UI for bookmarks import flow #6836

Are you sure you want to change the base?

UI for bookmarks import flow #6836

Uh oh!

Conversation

CDRussell commented Sep 23, 2025 • edited by cmonfortep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

Pre-import dialog

Web Flow, cancellations

Web flow, from a logged out state

Web flow, from a signed in state

Web flow, dev-only peeking at the WebView

Uh oh!

CDRussell commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonfortep left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmonfortep Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

cmonfortep Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

CDRussell Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CDRussell commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CDRussell commented Sep 23, 2025 •

edited by cmonfortep

Loading

CDRussell commented Sep 23, 2025 •

edited

Loading

CDRussell Oct 16, 2025 •

edited

Loading