[WIP] Compose Theme #6753
Draft
[WIP] Compose Theme #6753
+2,536
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we're using the latest activity update we need to make changes to onNeIntent as the signature has changed for the better. The intent is now marked as non-null so we can remove some safety checks Launch now only accepts a non-null intent so we have to check before launching the BookmarksActivity
This will be used so that our collections are considered "stable" when used in a Composable. For example, Compose does not consider "List" stable, so it will always recompose when recomposing the component's parent. See https://developer.android.com/develop/ui/compose/performance/stability
Quote: Strong Skipping is a mode available in the Compose compiler. When enabled, it changes the compiler's behavior in two ways: - Composables with unstable parameters become skippable - Lambdas with unstable captures are remembered https://developer.android.com/develop/ui/compose/performance/stability/strongskipping This is on by default in Kotlin 2.0.20 but we're not there yet.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Idea is to use this enforce only using our own TextStyle
…nd destructive styles
0nko
approved these changes
Oct 7, 2025
| import androidx.compose.ui.graphics.Color | ||
|
|
||
| @Immutable | ||
| data class DuckDuckGoColors( |
There was a problem hiding this comment.
There are some missing colors:
- canvas
- secondaryIcon
- shade
- shadeSolid
- accentContentPrimary
| val containerDisabled: Color, | ||
| val textDisabled: Color, | ||
| val ripple: Color, | ||
| val logoTitleText: Color, |
There was a problem hiding this comment.
Should these last 2 colors go to DuckDuckGoTextColors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description
Steps to test this PR
Feature 1
UI changes