Skip to content

set secret type extension #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

set secret type extension #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extension/httpfs/create_secret_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ void CreateS3SecretFunctions::RegisterCreateSecretFunction(DatabaseInstance &ins
secret_type.name = type;
secret_type.deserializer = KeyValueSecret::Deserialize<KeyValueSecret>;
secret_type.default_provider = "config";
secret_type.extension = "httpfs";

ExtensionUtil::RegisterSecretType(instance, secret_type);

Expand All @@ -225,6 +226,7 @@ void CreateBearerTokenFunctions::Register(DatabaseInstance &instance) {
secret_type_hf.name = HUGGINGFACE_TYPE;
secret_type_hf.deserializer = KeyValueSecret::Deserialize<KeyValueSecret>;
secret_type_hf.default_provider = "config";
secret_type_hf.extension = "httpfs";
ExtensionUtil::RegisterSecretType(instance, secret_type_hf);

// Huggingface config provider
Expand Down
17 changes: 17 additions & 0 deletions test/sql/secret/test_secret_type.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# name: test/sql/secret/test_secret_type.test
# description: Test the secret types added by this extension
# group: [httpfs]

require httpfs

statement ok
PRAGMA enable_verification

query II
SELECT type, default_provider from duckdb_secret_types() where extension='httpfs' order by type;
----
aws config
gcs config
huggingface config
r2 config
s3 config
Loading