Use HTTPException for HTTP errors in GetRangeRequest #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! LGTM - could you just resolve the conflicts? |
Instead of IOExceptions
Flogex
force-pushed
the
content-length-http-exception
branch
from
27a9f39 to
23824a3
Compare
Contributor
Author
|
I've rebased the branch on the latest main. |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the exceptions more consistent with the other ones thrown in
HTTPFileSystem::GetRangeRequest, this replaces twoIOExceptionswithHTTPExceptions. I think using anHTTPExceptionin these cases makes more sense because the error occurs during an HTTP request.