Skip to content

Pass profile into DefaultAWSCredentialsProviderChain and use it instead of ProfileConfigFileAWSCredentialsProvider #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pass profile into DefaultAWSCredentialsProviderChain and use it instead of ProfileConfigFileAWSCredentialsProvider #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3387b0b
Pass profile into DefaultAWSCredentialsProviderChain and use it inste…
nicornk Sep 18, 2025
1c442b8
triggger CI
nicornk Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/aws_extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@
if (!profile.empty()) {
// The user has specified a specific profile they want to use instead of the current profile specified by the
// system
Aws::Auth::ProfileConfigFileAWSCredentialsProvider provider(profile.c_str());
Aws::Client::ClientConfiguration::CredentialProviderConfiguration config;

Check failure on line 22 in src/aws_extension.cpp

View workflow job for this annotation

GitHub Actions / Minio Tests (<submodule_version>) 

‘CredentialProviderConfiguration’ is not a member of ‘Aws::Client::ClientConfiguration’
config.profile = profile.c_str()

Check failure on line 23 in src/aws_extension.cpp

View workflow job for this annotation

GitHub Actions / Minio Tests (<submodule_version>) 

‘struct duckdb::DBConfig’ has no member named ‘profile’
Aws::Auth::DefaultAWSCredentialsProviderChain provider(config);
credentials = provider.GetAWSCredentials();

Check failure on line 25 in src/aws_extension.cpp

View workflow job for this annotation

GitHub Actions / Minio Tests (<submodule_version>) 

‘provider’ was not declared in this scope
} else {
Aws::Auth::DefaultAWSCredentialsProviderChain provider;
credentials = provider.GetAWSCredentials();
Expand All @@ -29,7 +31,7 @@
auto s3_config = Aws::Client::ClientConfiguration(profile.c_str());
auto region = s3_config.region;

// TODO: We would also like to get the endpoint here, but it's currently not supported by the AWS SDK:
// TODO: We would also like to get the endpoint here, but it's currently not supported by the AWS Sdk:
// https://github.com/aws/aws-sdk-cpp/issues/2587

AwsSetCredentialsResult ret;
Expand Down Expand Up @@ -154,4 +156,4 @@
duckdb::LoadInternal(loader);
}

}
}
4 changes: 3 additions & 1 deletion src/aws_secret.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,10 @@
credentials = provider.GetAWSCredentials();
} else {
if (input.options.find("profile") != input.options.end()) {
Aws::Auth::ProfileConfigFileAWSCredentialsProvider provider(profile.c_str());
Aws::Client::ClientConfiguration::CredentialProviderConfiguration config;

Check failure on line 223 in src/aws_secret.cpp

View workflow job for this annotation

GitHub Actions / Minio Tests (<submodule_version>) 

‘CredentialProviderConfiguration’ is not a member of ‘Aws::Client::ClientConfiguration’
config.profile = profile.c_str()

Check failure on line 224 in src/aws_secret.cpp

View workflow job for this annotation

GitHub Actions / Minio Tests (<submodule_version>) 

‘config’ was not declared in this scope; did you mean ‘DBConfig’?
Aws::Auth::DefaultAWSCredentialsProviderChain provider(config);
credentials = provider.GetAWSCredentials();

Check failure on line 226 in src/aws_secret.cpp

View workflow job for this annotation

GitHub Actions / Minio Tests (<submodule_version>) 

‘provider’ was not declared in this scope
} else {
Aws::Auth::DefaultAWSCredentialsProviderChain provider;
credentials = provider.GetAWSCredentials();
Expand Down
Loading