Deduplicate parts of write_enum_operators into write_binary_bitwise_op. #1649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL?
Just a minor refactoring / no intended behavior changes - this PR:
fn write_binary_bitwise_op
out offn write_enum_operators
- the only difference betweenBitAnd
/BitOr
/BitXor
branches were theop
used (&
or|
or^
) in 1) the name ofoperatorFOO
and 2) in actual expression.enum_name
so that it can be directly used in formatting specifiers (instead of using{}
and then passingenm.name.cxx
as an arg)