Skip to content

Fix the ability to set custom reconnectAfterMs #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix the ability to set custom reconnectAfterMs #97

merged 1 commit into from
Oct 4, 2023

Conversation

@AH-MOC
Copy link

@AH-MOC AH-MOC commented Oct 4, 2023

Currently, setting custom reconnectAfterMs doesn't make sense since this var is applied to the reconnectTimer during the Socket class initializing.
The fix allows using custom reconnectAfterMs after the Socket object is created.

dsrees
dsrees approved these changes Oct 4, 2023
View reviewed changes
Copy link
Owner

@dsrees dsrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@dsrees dsrees merged commit b35e58d into dsrees:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsrees dsrees dsrees approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AH-MOC @dsrees @AndrewRage