Fix Concurrency issues with StateChange hooks and add/removing channels #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a few
ConcurrentModificationExceptionsoccurring. These are caused by clients adding a callback hook inside of a callback hook or modifying the channels while handling an error, etc.the solution is to make lists as read-only and then whenever adding or removing hooks and channels, use only concurrently safe operations by converting the read-only list to a new mutable list, adding the value, and then returning the new list.
This allows for looping over an existing list and adding a value to that list at the same time without modifying the underlying list while it's being looped over.