Skip to content

Conversation

@dsrees
Copy link
Owner

@dsrees dsrees commented Jun 20, 2019

  • Use a more aggressive reconnect algorithm
  • decouple socket reconnect algorithm with channel rejoin, socket side. Channel changes next
  • Fix socket never reconnecting after a heartbeat times out
  • Updated WebSocketTransport to call onClose after an onError event

@dsrees dsrees force-pushed the dr/refactor-reconnects branch from 41a5592 to 04f1e7d Compare June 20, 2019 02:36
@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #61 into master will increase coverage by 0.01%.
The diff coverage is 82.6%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
+ Coverage     91.22%   91.23%   +0.01%     
- Complexity      174      179       +5     
============================================
  Files             9        9              
  Lines           513      525      +12     
  Branches         66       69       +3     
============================================
+ Hits            468      479      +11     
- Misses           13       14       +1     
  Partials         32       32
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/org/phoenixframework/Transport.kt 83.33% <100%> (-0.67%) 0 <0> (ø)
src/main/kotlin/org/phoenixframework/Defaults.kt 90.9% <80%> (-9.1%) 5 <2> (+2)
src/main/kotlin/org/phoenixframework/Socket.kt 91.97% <82.35%> (-0.19%) 70 <5> (+2)
src/main/kotlin/org/phoenixframework/Push.kt 84% <0%> (+2%) 25% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11852b...04f1e7d. Read the comment docs.

@dsrees dsrees merged commit 84bdcd3 into master Jun 20, 2019
@dsrees dsrees deleted the dr/refactor-reconnects branch June 20, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants