Skip to content

test(phpstan): Fix node publish/unpublish calls in tests #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

test(phpstan): Fix node publish/unpublish calls in tests #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8d82c5
test(phpstan): Fix node publish/unpublish calls in tests
klausi Aug 31, 2023
f586864
Ignore prophesize calls
klausi Aug 31, 2023
1637925
restore original ignore rule
klausi Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
webonyx/graphql-php:^14.8 \
drupal/typed_data:^1.0 \
drupal/redirect:^1.0 \
phpstan/phpstan:^1.7.14 \
phpstan/phpstan:^1.10.32 \
mglaman/phpstan-drupal:^1.1.2 \
phpstan/phpstan-deprecation-rules:^1.0.0 \
jangregor/phpstan-prophecy:^1.0.0 \
Expand Down
3 changes: 3 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ parameters:
# Not sure we can specify generic types properly with Drupal coding standards
# yet, disable for now.
checkGenericClassInNonGenericObjectType: false
# Sometimes we have a mismatch between local execution and CI, we don't care
# about ignored errors that are not triggered.
reportUnmatchedIgnoredErrors: false
excludePaths:
# Exclude the RouteLoad producer because the redirect module is not D10
# compatible so we are not downloading it.
Expand Down
12 changes: 6 additions & 6 deletions tests/src/Kernel/DataProducer/Routing/RouteEntityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ public function setUp(): void {
$this->unpublished_node->save();

$this->translation_fr_unpublished = $this->unpublished_node->addTranslation('fr', ['title' => 'Test Unpublished Event FR']);
$this->translation_fr_unpublished->status = NodeInterface::NOT_PUBLISHED;
$this->translation_fr_unpublished->setUnpublished();
$this->translation_fr_unpublished->save();

$this->translation_de_unpublished = $this->unpublished_node->addTranslation('de', ['title' => 'Test Unpublished Event DE']);
$this->translation_de_unpublished->status = NodeInterface::NOT_PUBLISHED;
$this->translation_de_unpublished->setUnpublished();
$this->translation_de_unpublished->save();

// Unpublished node to published translations.
Expand All @@ -68,11 +68,11 @@ public function setUp(): void {
$this->unpublished_to_published_node->save();

$this->translation_fr_unpublished_to_published = $this->unpublished_to_published_node->addTranslation('fr', ['title' => 'Test Unpublished to Published Event FR']);
$this->translation_fr_unpublished_to_published->status = NodeInterface::PUBLISHED;
$this->translation_fr_unpublished_to_published->setPublished();
$this->translation_fr_unpublished_to_published->save();

$this->translation_de_unpublished_to_published = $this->unpublished_to_published_node->addTranslation('de', ['title' => 'Test Unpublished to Published Event DE']);
$this->translation_de_unpublished_to_published->status = NodeInterface::PUBLISHED;
$this->translation_de_unpublished_to_published->setPublished();
$this->translation_de_unpublished_to_published->save();

// Published node to unpublished translations.
Expand All @@ -84,11 +84,11 @@ public function setUp(): void {
$this->published_to_unpublished_node->save();

$this->translation_fr_published_to_unpublished = $this->published_to_unpublished_node->addTranslation('fr', ['title' => 'Test Published to Unpublished Event FR']);
$this->translation_fr_published_to_unpublished->status = NodeInterface::NOT_PUBLISHED;
$this->translation_fr_published_to_unpublished->setUnpublished();
$this->translation_fr_published_to_unpublished->save();

$this->translation_de_published_to_unpublished = $this->published_to_unpublished_node->addTranslation('de', ['title' => 'Test Published to Unpublished Event DE']);
$this->translation_de_published_to_unpublished->status = NodeInterface::NOT_PUBLISHED;
$this->translation_de_published_to_unpublished->setUnpublished();
$this->translation_de_published_to_unpublished->save();

\Drupal::service('content_translation.manager')->setEnabled('node', 'event', TRUE);
Expand Down