[PATCH] Add optional language parameter to route_load data producer #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausi
approved these changes
Nov 12, 2023
Contributor
klausi
left a comment
klausi
left a comment
There was a problem hiding this comment.
Looks good to me, I have 2 minor comments that I will fix in a follow-up.
| */ | ||
| public function resolve($path, RefinableCacheableDependencyInterface $metadata) { | ||
| $redirect = $this->redirectRepository ? $this->redirectRepository->findMatchingRedirect($path, []) : NULL; | ||
| public function resolve($path, $language, RefinableCacheableDependencyInterface $metadata) { |
Contributor
There was a problem hiding this comment.
we should use type hints for all new parameters, in this case string.
| * ), | ||
| * "language" = @ContextDefinition("string", | ||
| * label = @Translation("Language"), | ||
| * required = FALSE |
Contributor
There was a problem hiding this comment.
we should specify a default value und here, which is Language::LANGCODE_NOT_SPECIFIED
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.