Skip to content

(maint) fixing naming and add more go best practice #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

(maint) fixing naming and add more go best practice #211

merged 1 commit into from
Jul 26, 2022

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Jul 26, 2022 •
edited
Loading 

➜  go-scm git:(naming_conventions) find  . -name "*.go" | grep -E '[a-z]{1,}[A-Z]'
➜  go-scm git:(naming_conventions)

no more camelCase
#208

This linting only affect new PR's encoming

@tphoney tphoney force-pushed the naming_conventions branch 5 times, most recently from 179fae9 to acb7182 Compare July 26, 2022 10:33
@tphoney tphoney force-pushed the naming_conventions branch 2 times, most recently from 9e9e7c3 to c16961a Compare July 26, 2022 13:20
@tphoney tphoney force-pushed the naming_conventions branch from c16961a to 99b9843 Compare July 26, 2022 13:45
@tphoney tphoney marked this pull request as ready for review July 26, 2022 13:52
@tphoney tphoney merged commit b8f5fce into drone:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eoinmcafee00 eoinmcafee00 eoinmcafee00 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tphoney @eoinmcafee00 @bradrydzewski