added utility to write artifact file #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham149
approved these changes
May 3, 2023
donny-dont
reviewed
May 3, 2023
go.mod
Outdated
| go 1.19 | ||
|
|
||
| require ( | ||
| github.com/pkg/errors v0.9.1 |
Collaborator
There was a problem hiding this comment.
Please don’t add this package back. Use normal go error wrapping.
Collaborator
There was a problem hiding this comment.
This is already merged but what I was suggesting was to use the error wrapping that was added in Go 1.13 which made the errors package obsolete. See https://go.dev/blog/go1.13-errors
tphoney
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.