Remove temp tag from build and prune afterwards #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will untag the "temp" tag (
p.Build.Name) from the image so thatdocker system prunecan properly clean it up. Currentlydocker system prunedoes nothing.However, this PR will not work until Docker 17.04 is released as there is a bug prior to that where
docker system prunedoes not properly clean dangling images. moby/moby#32006So I just wanted to get this code/issue in the open. We can either merge knowing it won't really do anything until 17.04 is released and the plugin uses it ... or wait until 17.04 is released and the plugin is using it before merging.