Skip to content

Conversation

@jmccann
Copy link

@jmccann jmccann commented Mar 22, 2017

This PR will untag the "temp" tag (p.Build.Name) from the image so that docker system prune can properly clean it up. Currently docker system prune does nothing.

However, this PR will not work until Docker 17.04 is released as there is a bug prior to that where docker system prune does not properly clean dangling images. moby/moby#32006

So I just wanted to get this code/issue in the open. We can either merge knowing it won't really do anything until 17.04 is released and the plugin uses it ... or wait until 17.04 is released and the plugin is using it before merging.

@bradrydzewski
Copy link
Member

bradrydzewski commented Apr 10, 2017

thanks, do you want to update the PR to include the changes to 17.04? This would be similar to #114. Note that I was holding up #114 until #116 was implemented, but at this point I see no good reason to block on that change. Can always do a follow up for #116 later

@jmccann jmccann mentioned this pull request Apr 10, 2017
@jmccann
Copy link
Author

jmccann commented May 15, 2017

Now that #122 and #124 have been merged this should be ready to go.

@bradrydzewski bradrydzewski merged commit 4904d5c into drone-plugins:master May 15, 2017
@jmccann jmccann deleted the remove_temp_layers branch May 15, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants