Skip to content

Conversation

@mwq27
Copy link

@mwq27 mwq27 commented Sep 10, 2014

...alse. Assertion added to the test-request-methods.js tests. Closes #71

…r false. Assertion added to the test-request-methods.js tests.
@kumavis
Copy link
Contributor

kumavis commented Jan 19, 2015

I think this is incorrect,
xhr.withCredentials is a boolean that you set, not a function

@kumavis
Copy link
Contributor

kumavis commented Jan 19, 2015

Furthermore, it should be passed on to the options for doRequest b/c if undefined, defaults to xhr.withCredentials = true which is not the default behaviour of the browser

request = doRequest(options, responseHandler).on("error", errorHandler);

kumavis added a commit to kumavis/node-XMLHttpRequest that referenced this pull request Jan 19, 2015
@driverdan
Copy link
Owner

Fixed in #96

@driverdan driverdan closed this Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to define withCredentials

3 participants