Support IPv6 URIs #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `URI::Generic#host`, we should use `#hostname`. The only difference between these methods is that `#hostname` will unwrap brackets from URIs that look like literal IPv6 addresses.
|
It looks like there isn't enough infrastructure to test this right now, you'd want to assert that the value passed in here is the correct IPv6 hostname, but there's no tests for that class. I can add tests. You may want to update the tests to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
URI::Generic#host, we should use#hostname. The only difference between these methods is that#hostnamewill unwrap brackets from URIs that look like literal IPv6 addresses.I don't know how to test this, however, short of booting up a webrick instance and actually making requests, but that seems a bit overkill.
See lostisland/faraday#621 for more background.