Handle Net::HTTP#verify_hostname in SSL Context if available #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cosmo0920
force-pushed
the
handle-verify_hostname-in-ssl-context
branch
2 times, most recently
from
4a92535 to
8a85e43
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
handle-verify_hostname-in-ssl-context
branch
from
8a85e43 to
f786454
Compare
|
ping? |
olleolleolle
reviewed
Feb 2, 2022
Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Net::HTTP#verify_hostnamewas added in Ruby 3.0 or later.I think that net/http/persistent should be thin wrapper, so, we should handle
Handle Net::HTTP#verify_hostnamein this gem.This option can work with Ruby 3.0 or later.
WDYT?
Signed-off-by: Hiroshi Hatake [email protected]