Skip to content

Changes for aligning code with offset fetch and commit APIs (Kafka 0.8.1) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2014
Merged

Changes for aligning code with offset fetch and commit APIs (Kafka 0.8.1) #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5581649
Syncing offset commit and fetch api keys with Kafka trunk code
Jan 7, 2014
daabc9f
Deleting client_id from offset commit and fetch response as per Kafka…
Jan 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions kafka/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ class KafkaProtocol(object):
FETCH_KEY = 1
OFFSET_KEY = 2
METADATA_KEY = 3
OFFSET_COMMIT_KEY = 6
OFFSET_FETCH_KEY = 7
OFFSET_COMMIT_KEY = 8
OFFSET_FETCH_KEY = 9

ATTRIBUTE_CODEC_MASK = 0x03
CODEC_NONE = 0x00
Expand Down Expand Up @@ -439,7 +439,6 @@ def decode_offset_commit_response(cls, data):
data: bytes to decode
"""
((correlation_id,), cur) = relative_unpack('>i', data, 0)
(client_id, cur) = read_short_string(data, cur)
((num_topics,), cur) = relative_unpack('>i', data, cur)

for i in xrange(num_topics):
Expand Down Expand Up @@ -490,7 +489,6 @@ def decode_offset_fetch_response(cls, data):
"""

((correlation_id,), cur) = relative_unpack('>i', data, 0)
(client_id, cur) = read_short_string(data, cur)
((num_topics,), cur) = relative_unpack('>i', data, cur)

for i in range(num_topics):
Expand Down