reduce memory copies when consuming kafka responses #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eklitzke looks good to me, I'll go ahead and merge. Would you happen to have any timings comparing the current code with this? |
mumrah
added a commit
that referenced
this pull request
Dec 28, 2013
reduce memory copies when consuming kafka responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a simple change that uses the
.join()method of strings to join the chunks read from kafka. This reduces memory copies and memory allocations, as the joined string can be allocated all at once, rather than for each chunk. This improvement is especially noticeable when reading large messages.I've also fixed a typo in the docstring.