Skip to content

Raise AssertionError if consumer closed in poll() #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Raise AssertionError if consumer closed in poll() #1978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb684cc
Raise AssertionError if consumer closed in poll()
dpkp Dec 29, 2019
65b343d
StopIteration when consumer closed
dpkp Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kafka/consumer/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,7 @@ def poll(self, timeout_ms=0, max_records=None, update_offsets=True):
max_records = self.config['max_poll_records']
assert isinstance(max_records, int), 'max_records must be an integer'
assert max_records > 0, 'max_records must be positive'
assert not self._closed, 'KafkaConsumer is closed'

# Poll for new data until the timeout expires
start = time.time()
Expand Down Expand Up @@ -1173,6 +1174,8 @@ def __iter__(self): # pylint: disable=non-iterator-returned
return self

def __next__(self):
if self._closed:
raise StopIteration('KafkaConsumer closed')
# Now that the heartbeat thread runs in the background
# there should be no reason to maintain a separate iterator
# but we'll keep it available for a few releases just in case
Expand Down