create round-robin partitioner starting from a random partition #1608
Conversation
There was a problem hiding this comment.
I'm pretty hesitant to take this as the RoundRobinPartitioner is a leftover from the SimpleProducer days... in fact I'm planning on removing it in #1196.
If you use the new KafkaProducer, then the default partitioner it ships with will use a random partition by default if the key is not provided... would that achieve what you're looking for? It's not technically the same as starting from a random seed and then round-robin'ing, but it's probably close enough for most use cases.
Also, in general we try to follow the Java clients, so this would be better to submit upstream as a KIP and see what the broader community thinks of it. If they choose to pull it in, then happy to take it here as well.
Marking as needing changes until we get this resolved...
|
Sorry, but going to reject based on the above comment.... We love PRs, but you'll want to do them against the new |
|
Thanks!
…On Wed, 31 Oct 2018 at 8:13 Jeff Widman ***@***.***> wrote:
Closed #1608 <#1608>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1608 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AINH1Pa2cIkOf9ZAGawdMJwHFsgeiVhDks5uqT97gaJpZM4X2iBP>
.
|
This partitioner is useful while using multiple producers that produce limited amount of records.
Instead of using RoundRobinPartitioner which always starts from the first partition (causing unbalanced partitions) this one will pick a random partition to start from.
This change is