Skip to content

Always use OffsetFetchRequest in consumers #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Always use OffsetFetchRequest in consumers #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fe5be4
Always use OffsetFetchRequest in consumers
jersub Apr 11, 2014
8ba017a
Update kafka-src to 0.8.1
jersub Apr 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka-src
Open in desktop
Submodule kafka-src updated 340 files
18 changes: 7 additions & 11 deletions kafka/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from kafka.common import (
ErrorMapping, FetchRequest,
OffsetRequest, OffsetCommitRequest,
OffsetRequest, OffsetCommitRequest, OffsetFetchRequest,
ConsumerFetchSizeTooSmall, ConsumerNoMoreData
)

Expand Down Expand Up @@ -105,17 +105,13 @@ def get_or_init_offset_callback(resp):
"partition=%d failed with errorcode=%s" % (
resp.topic, resp.partition, resp.error))

# Uncomment for 0.8.1
#
#for partition in partitions:
# req = OffsetFetchRequest(topic, partition)
# (offset,) = self.client.send_offset_fetch_request(group, [req],
# callback=get_or_init_offset_callback,
# fail_on_error=False)
# self.offsets[partition] = offset

for partition in partitions:
self.offsets[partition] = 0
req = OffsetFetchRequest(topic, partition)
(offset,) = self.client.send_offset_fetch_request(
group, [req],
callback=get_or_init_offset_callback,
fail_on_error=False)
self.offsets[partition] = offset

def commit(self, partitions=None):
"""
Expand Down