Skip to content

Remove ConsumerTimeout #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2018
Merged

Remove ConsumerTimeout #1587

merged 1 commit into from
Sep 27, 2018

Conversation

emord
Copy link
Contributor

@emord emord commented Sep 8, 2018 •
edited by dpkp
Loading

This error hasn't been thrown since 1.2.4 and I do not see it anywhere else in the library.

https://github.com/dpkp/kafka-python/blob/bc4cc434cddf403a35d0393d68ecfdbfad17c8e5/docs/changelog.rst#124-july-8-2016

This change is Reviewable

jeffwidman
jeffwidman approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@jeffwidman jeffwidman merged commit ba7372e into dpkp:master Sep 27, 2018
@emord emord deleted the patch-1 branch September 27, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jeffwidman jeffwidman jeffwidman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emord @jeffwidman