Stop shadowing ConnectionError
#1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python3, `ConnectionError` is a native exception. So rename our custom one to `KafkaConnectionError` to prevent accidentally shadowing the native one. Note that there are still valid uses of `ConnectionError` in this code. They already expect a native Python3 `ConnectionError`, and also already handle the Python2 compatibility issues.
jeffwidman
force-pushed
the
Stop-shadowing-native-python-ConnectionError-exception
branch
from
ea3f2b8 to
c9fba20
Compare
|
Note that this is a breaking change for anyone who did |
|
@tvoinarovskyi / @dpkp can one of you review? I don't trust the test suite is executing all these code paths... |
jeffwidman
deleted the
Stop-shadowing-native-python-ConnectionError-exception
branch
|
Sorry for being so late, it's a good PR. 1 moment thou, we don't want to break existing code, so we should make an alias for ConnectionError in errors.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python3,
ConnectionErroris a native exception. So rename our custom one toKafkaConnectionErrorto prevent accidentally shadowing the native one.Note that there are still valid uses of
ConnectionErrorin this code.They already expect a native Python3
ConnectionError, and also alreadyhandle the Python2 compatibility issues.