Name heartbeat thread with group_id; use backoff when polling #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Jan 12, 2018
tvoinarovskyi
approved these changes
Jan 12, 2018
|
This is causing problems on pypy for some reason. Needs investigation. |
|
A bit too trigger happy |
|
I'm not sure what's wrong with me today. The thread rename should be merged. The timeout change should not. I'm just going to push that manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another set of small improvements that I stashed while working on other PRs. To help with log analysis we can name the heartbeat thread using the consumer group_id . I've also added a short timeout to the internal heartbeat poll to avoid tight loops.