Skip to content

Conversation

OrangePieiep
Copy link
Contributor

Use "9999999999" or "999999999" for max value might be not proper. This is a little bit misleading and might cause potential issues.

@dpkp
Copy link
Owner

dpkp commented Dec 5, 2017

Apologies -- all test fixtures were failing due to an unrelated issue. Please pull latest changes from master and re-run tests.

@OrangePieiep
Copy link
Contributor Author

Hi dpkp,

Do I need to give a new pull request to trigger the CI build test, or I can somehow restart the test manually ?

-Luke

@dpkp
Copy link
Owner

dpkp commented Dec 6, 2017

You can pull master, rebase, and force push the update back to your branch (or you can merge and push the merge commit).

@dpkp dpkp merged commit 009290d into dpkp:master Dec 7, 2017
@dpkp
Copy link
Owner

dpkp commented Dec 7, 2017

Thanks!

@OrangePieiep
Copy link
Contributor Author

Sure. If you have bugs or features need to tackle, please let me know. I'd like to help.

@jeffwidman
Copy link
Contributor

jeffwidman commented Dec 9, 2017

@lukekingbru I recommend skimming https://github.com/dpkp/kafka-python/issues for any issues that have a KAFKA-XXXX jira ticket attached or a KIP attached... those are ones we generally know we want to implement. For example #1122 might be a good one to start with that is fairly self-contained.

@OrangePieiep
Copy link
Contributor Author

Thanks so much, Let me dig into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants